Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-force-repl #14439

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-force-repl #14439

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 23, 2017

test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

@Trott Trott added repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels Jul 23, 2017
gibfahn
gibfahn reviewed Jul 24, 2017
View reviewed changes
test/parallel/test-force-repl.js Outdated
@@ -5,14 +5,10 @@ const spawn = require('child_process').spawn;

// spawn a node child process in "interactive" mode (force the repl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: While you're here, maybe spruce up the comment formatting?

e.g.

// Spawn a child node process in "interactive" mode (enabling the repl),
// and ensure '> ' is emitted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment formatting spruced up. Comment expanded.

@refack
Copy link
Contributor

refack commented Jul 24, 2017

test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

I assume a it's pre-mustCall mechanism

@Trott Trott force-pushed the fix-flaky-test-force-repl branch from f3fcf2f to 1179ba6 Compare July 26, 2017 13:42
@Trott
test: fix flaky test-force-repl
6b164e9 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.
@Trott Trott force-pushed the fix-flaky-test-force-repl branch from 1179ba6 to 6b164e9 Compare July 26, 2017 13:45
@Trott
Copy link
Member Author

Trott commented Jul 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9357/

@Trott
Copy link
Member Author

Trott commented Jul 26, 2017

Landed in 8f01025

@Trott Trott closed this Jul 26, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jul 26, 2017
@Trott
test: fix flaky test-force-repl
8f01025 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: nodejs#14439
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 27, 2017
@Trott @addaleax
test: fix flaky test-force-repl
14f6a5a 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: fix flaky test-force-repl
2a094c5 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: fix flaky test-force-repl
b9a5253 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
@Trott @MylesBorins
test: fix flaky test-force-repl
89cb5cc 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@Trott @MylesBorins
test: fix flaky test-force-repl
95a95cc 
test/parallel/test-force-repl.js has an unnecessary timer that makes the
test flaky under load. Remove it.

PR-URL: #14439
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Sep 6, 2017
Closed
@Trott Trott deleted the fix-flaky-test-force-repl branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @refack @jasnell @addaleax @lpinca @cjihrig @gibfahn @MylesBorins