test: make flaky crypto test more deterministic #14451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filenames of crypto tests should start with 'test-crypto-' and now it does.
jasnell
approved these changes
Jul 24, 2017
refack
approved these changes
Jul 24, 2017
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 27, 2017
Filenames of crypto tests should start with 'test-crypto-' and now it does. PR-URL: nodejs#14451 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 27, 2017
Fixes: nodejs#14424 PR-URL: nodejs#14451 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
Filenames of crypto tests should start with 'test-crypto-' and now it does. PR-URL: #14451 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
Fixes: #14424 PR-URL: #14451 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
This is breaking V8 6.0 as the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is happy (closest buildbot pending nodejs/build#813)
Fixes: #14424