test: remove disabled tests directory #14505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
https
There is only one test left in the disabled test directory and it does not seem worth saving.
lpinca
approved these changes
Jul 26, 2017
addaleax
approved these changes
Jul 26, 2017
evanlucas
approved these changes
Jul 26, 2017
cjihrig
approved these changes
Jul 26, 2017
Fishrock123
approved these changes
Jul 26, 2017
tniessen
approved these changes
Jul 26, 2017
XadillaX
approved these changes
Jul 27, 2017
|
Landed in 0fab3b0 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 29, 2017
There is only one test left in the disabled test directory and it does not seem worth saving. PR-URL: nodejs#14505 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 29, 2017
There is only one test left in the disabled test directory and it does not seem worth saving. PR-URL: #14505 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Merged
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one test left in the disabled test directory and it does
not seem worth saving.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test https