Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix shared library flags logic #1454

Closed
wants to merge 0 commits into from

Conversation

Fishrock123
Copy link
Contributor

An even smaller fix than #1450

See: #1436 (comment)

@Fishrock123 Fishrock123 added this to the 1.8.0 milestone Apr 17, 2015
@Fishrock123 Fishrock123 added the build Issues and PRs related to build files or the CI. label Apr 17, 2015
@chrisdickinson
Copy link
Contributor

LGTM, land at will.

@jbergstroem
Copy link
Member

LGTM, feel free to land.

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Apr 17, 2015
Fixes a regession introduced in fd90b33

PR-URL: nodejs#1454
Reviewed-By: Chris Dickinson <[email protected]>
@Fishrock123
Copy link
Contributor Author

@jbergstroem thanks, didn't get you in on the Reviewed-By though.

Landed in 1b22bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants