Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] zlib: fix interaction of flushing and needDrain #14571

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 1, 2017

Fixes: #14523
Backport of: #14527

The conflicts were only in zlib.js.

Fixes: nodejs#14523
PR-URL: nodejs#14527
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@nodejs-github-bot nodejs-github-bot added v8.x zlib Issues and PRs related to the zlib subsystem. labels Aug 1, 2017
@addaleax
Copy link
Member Author

addaleax commented Aug 1, 2017

addaleax added a commit that referenced this pull request Aug 2, 2017
Backport-PR-URL: #14571
Backport-Reviewed-By: James M Snell <[email protected]>

Fixes: #14523
PR-URL: #14527
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@addaleax
Copy link
Member Author

addaleax commented Aug 2, 2017

Landed in e529914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants