Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: properly manage timer in cares ChannelWrap #14634

Closed
wants to merge 5 commits into from
Closed

src: properly manage timer in cares ChannelWrap #14634

wants to merge 5 commits into from

Commits on Aug 4, 2017

  1. src: properly manage timer in cares ChannelWrap 

    This fixes a bug introduced in 727b291
where code managing the `uv_timer_t` for a `ChannelWrap` instance was
left unchanged, when it should have changed the lifetime of the handle
to being tied to the `ChannelWrap` instance’s lifetime.

Fixes: nodejs#14599
Ref: nodejs#14518
    @addaleax
    addaleax committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    3baafef View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2017

  1. addressing indutny comments

    Refael Ackermann authored Aug 5, 2017
    Configuration menu
    Copy the full SHA
    e764842 View commit details
    Browse the repository at this point in the history

  2. nullptr

    Refael Ackermann authored Aug 5, 2017
    Configuration menu
    Copy the full SHA
    1fdf0ac View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. [squash] undo pointless change

    @addaleax
    addaleax committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    75885f3 View commit details
    Browse the repository at this point in the history

  2. [squash] style nit

    @addaleax
    addaleax committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    8a19e57 View commit details
    Browse the repository at this point in the history