Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.1.534.38 #15431

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.1.534.38 #15431

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

created using the update-v8 npm module and the command

update-v8 minor

I've reviewed the patch and can confirm it contains all changes
from 6.1.534.36 -> 6.1.534.38

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 15, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
1839833 
created using the update-v8 npm module and the command

`update-v8 minor`

I've reviewed the patch and can confirm it contains all changes
from 6.1.534.36 -> 6.1.534.38
@MylesBorins
Copy link
Contributor Author

This should be cherry-picked to #15393

@addaleax addaleax mentioned this pull request Sep 15, 2017
Closed
2 tasks
jasnell
jasnell approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp LGTM

@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10096/

v8-ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/907/

fhinkel
fhinkel approved these changes Sep 16, 2017
View reviewed changes
deps/v8/include/v8-version.h
@@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 6
#define V8_MINOR_VERSION 1
#define V8_BUILD_NUMBER 534
#define V8_PATCH_LEVEL 36
#define V8_PATCH_LEVEL 38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another open patch going to 37?

Copy link
Member

@targos targos Sep 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change in flag-definitions.h is the patch 37

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly. This patch includes both 37 + 38

@fhinkel
Copy link
Member

fhinkel commented Sep 16, 2017

Restarted the CI:
https://ci.nodejs.org/job/node-test-pull-request/10110/
https://ci.nodejs.org/job/node-test-commit-v8-linux/908/

@gibfahn
Copy link
Member

gibfahn commented Sep 17, 2017

Maybe worth including the upstream hashes:

v8/v8@35b4f6e
v8/v8@eeb87aa

@targos
Copy link
Member

targos commented Sep 18, 2017

I usually include the compare link: v8/v8@6.1.534.36...6.1.534.38

@targos
Copy link
Member

targos commented Sep 18, 2017

Landed in 9b996f0.

@targos targos closed this Sep 18, 2017
targos pushed a commit that referenced this pull request Sep 18, 2017
@MylesBorins @targos
deps: patch V8 to 6.1.534.38
9b996f0 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: #15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Sep 21, 2017
@MylesBorins @targos
deps: patch V8 to 6.1.534.38
133b51d 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: nodejs#15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
ef1c2b6 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: nodejs/node#15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
04f6659 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: nodejs/node#15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins added a commit that referenced this pull request Sep 28, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
1da78cd 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins added a commit that referenced this pull request Sep 29, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
f290e5d 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins added a commit that referenced this pull request Oct 3, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
8471747 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins deleted the update-6.1-lkgr branch November 14, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@ofrobots ofrobots ofrobots approved these changes

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MylesBorins @fhinkel @gibfahn @targos @ofrobots @jasnell @addaleax @nodejs-github-bot