Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: add check for large strings #15611

Closed
wants to merge 3 commits into from
Closed

n-api: add check for large strings #15611

wants to merge 3 commits into from

Commits on Sep 25, 2017

  1. n-api: add check for large strings 

    n-api uses size_t for the size of strings when specifying
string lengths.  V8 only supports a size of int.  Add
a check so that an error will be returned if the user
passes in a string with a size larger than will fit into
an int.
    @mhdawson
    mhdawson committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    6fdd2e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. squash: address comments

    @mhdawson
    mhdawson committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    d319160 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. squash: fix test failures on 32bit platforms

    @mhdawson
    mhdawson committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    ff719da View commit details
    Browse the repository at this point in the history