Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate smalloc functions #1565

Merged
merged 3 commits into from
Apr 29, 2015
Merged

Deprecate smalloc functions #1565

merged 3 commits into from
Apr 29, 2015

Commits on Apr 29, 2015

  1. src: fix NODE_DEPRECATED macro 

    The NODE_DEPRECATED macro was piggybacking on the V8_DEPRECATED macro
but that macro is silent unless V8_DEPRECATION_WARNINGS is defined,
something io.js doesn't do.  Ergo, no deprecation notices were being
issued.

PR-URL: nodejs#1565
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    609fa0d View commit details
    Browse the repository at this point in the history

  2. src: fix deprecation warnings 

    The previous commit enables deprecation warnings, this commit fixes
the handful of offending sites where the isolate was not explicitly
being passed around.

PR-URL: nodejs#1565
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    ccb199a View commit details
    Browse the repository at this point in the history

  3. src: deprecate smalloc public functions 

    Upcoming V8 changes will make it impossible to keep supporting the
smalloc functionality so deprecate the functions in smalloc.h now
and tell people to switch to typed arrays.

This commit shuffles code around in smalloc.cc to avoid generating
the deprecation warnings when building io.js itself.

PR-URL: nodejs#1565
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    7306252 View commit details
    Browse the repository at this point in the history