http: do not blindly destroy UNIX domain sockets #15650
Closed
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a better commit message might be: 'http: do not blindly destroy UNIX domain sockets' |
`Connection: keep-alive` is now properly supported when making client connections to UNIX domain sockets so `request.abort()` should not blindly destroy the underlying socket. Refs: nodejs#13214 (comment)
lpinca
force-pushed
the
fix/uds-keep-alive
branch
from
7f213d8
to
a12dce0
Compare
|
@mscdex done, thank you. |
lpinca
changed the title
|
Is there a particular reason this stalled? ping @nodejs/http |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/10826/ Last one is no longer available. |
|
CI is good, all known failures. |
apapirovski
approved these changes
Oct 19, 2017
|
@lpinca you should be good to merge this, if you want. |
|
@apapirovski go for it if you have time. |
|
Landed in eb2fbd1 |
apapirovski
pushed a commit
that referenced
this pull request
Oct 23, 2017
`Connection: keep-alive` is now properly supported when making client connections to UNIX domain sockets so `request.abort()` should not blindly destroy the underlying socket. PR-URL: #15650 Refs: #13214 (comment) Reviewed-By: Anatoli Papirovski <[email protected]>
|
This depends on #13214 so applying the same label re: v6.x |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
`Connection: keep-alive` is now properly supported when making client connections to UNIX domain sockets so `request.abort()` should not blindly destroy the underlying socket. PR-URL: #15650 Refs: #13214 (comment) Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
`Connection: keep-alive` is now properly supported when making client connections to UNIX domain sockets so `request.abort()` should not blindly destroy the underlying socket. PR-URL: nodejs/node#15650 Refs: nodejs/node#13214 (comment) Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
`Connection: keep-alive` is now properly supported when making client connections to UNIX domain sockets so `request.abort()` should not blindly destroy the underlying socket. PR-URL: nodejs/node#15650 Refs: nodejs/node#13214 (comment) Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection: keep-aliveis now properly supported when making clientconnections to UNIX domain sockets so
request.abort()should notblindly destroy the underlying socket.
Refs: #13214 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http