Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace manual memory mgmt with std::string #15782

Closed
wants to merge 1 commit into from
Closed

src: replace manual memory mgmt with std::string #15782

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Oct 5, 2017 •
edited
Loading

(For this one thing, not in general. That didn't fit in 50 columns, though.)

CI: https://ci.nodejs.org/job/node-test-pull-request/10413/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Oct 5, 2017
jasnell pushed a commit that referenced this pull request Oct 9, 2017
@bnoordhuis @jasnell
src: replace manual memory mgmt with std::string
fca31be 
PR-URL: #15782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 9, 2017

Landed in fca31be

@jasnell jasnell closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@bnoordhuis @MylesBorins
src: replace manual memory mgmt with std::string
e4c461b 
PR-URL: #15782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@bnoordhuis @addaleax
src: replace manual memory mgmt with std::string
cb46497 
PR-URL: nodejs/node#15782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

@bnoordhuis this lands cleanly on v6.x

Should we backport?

@bnoordhuis
Copy link
Member Author

@MylesBorins Yes, good idea.

MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@bnoordhuis @MylesBorins
src: replace manual memory mgmt with std::string
d01978e 
PR-URL: #15782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 19, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@bnoordhuis @MylesBorins
src: replace manual memory mgmt with std::string
cdba989 
PR-URL: #15782
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bnoordhuis @jasnell @MylesBorins @danbev @addaleax @TimothyGu @cjihrig @JungMinu @nodejs-github-bot