Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir w/ fixtures.path #15819

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir w/ fixtures.path #15819

wants to merge 1 commit into from

Conversation

Druotic
Copy link
Contributor

@Druotic Druotic commented Oct 6, 2017 •
edited
Loading

Description

In test/parallel/test-tls-connect-secure-context.js, replace common.fixturesDir with usage of the common.fixtures module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Simple test change for Node Interactive code and learn session.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@lpinca
Copy link
Member

lpinca commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10526/

@lpinca
Copy link
Member

lpinca commented Oct 9, 2017 •
edited
Loading

There is a small typo in commit message: fixutres.path.

@Druotic Druotic force-pushed the test-tls-connect-secure-context-common-fixtures branch from 62e38e3 to 3f62305 Compare October 9, 2017 10:04
@Druotic Druotic changed the title test: replace common.fixturesDir w/ fixutres.path test: replace common.fixturesDir w/ fixtures.path Oct 9, 2017
@Druotic
Copy link
Contributor Author

Druotic commented Oct 9, 2017

Fixed the typo. @lpinca

@lpinca
Copy link
Member

lpinca commented Oct 10, 2017

Landed in 85a5a2c.

lpinca pushed a commit that referenced this pull request Oct 10, 2017
@Druotic @lpinca
test: replace common.fixturesDir w/ fixtures.path
85a5a2c 
PR-URL: #15819
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@lpinca lpinca closed this Oct 10, 2017
@Trott
Copy link
Member

Trott commented Oct 10, 2017

Thanks for the contribution! 🎉

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
6f42b68 
PR-URL: #15819
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@Druotic @addaleax
test: replace common.fixturesDir w/ fixtures.path
4f7bb10 
PR-URL: nodejs/node#15819
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
ba7ba10 
PR-URL: #15819
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
24f620e 
PR-URL: #15819
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@Druotic @MylesBorins
test: replace common.fixturesDir w/ fixtures.path
08ca73f 
PR-URL: #15819
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.