Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update 'fixturesDir' refs in a test file #15824

Closed
wants to merge 1 commit into from
Closed

test: update 'fixturesDir' refs in a test file #15824

wants to merge 1 commit into from

Conversation

JamesMGreene
Copy link
Contributor

@JamesMGreene JamesMGreene commented Oct 6, 2017 •
edited
Loading

This was a task from Code & Learn at NINA17.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Thanks @jasnell 💝

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
pawelgolda
pawelgolda reviewed Oct 6, 2017
View reviewed changes
test/parallel/test-http-url.parse-https.request.js Outdated
@@ -31,8 +32,8 @@ const fs = require('fs');

// https options
const httpsOptions = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fs.readFileSync(`${fixturesDir}/keys/agent1-key.pem`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I followed the distributed Code & Learn task description pretty literally, so this thought never occurred to me. Thanks for the tip. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. Updated with another commit.

@tniessen
Copy link
Member

tniessen commented Oct 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10425/

@JamesMGreene
test: update 'fixturesDir' refs in a test file
86727f6 
This was a task from Code & Learn at NINA17.
@JamesMGreene
Copy link
Contributor Author

I've squashed the commits for this.

rmg
rmg approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@rmg rmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for contributing!

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@refack
Copy link
Contributor

refack commented Oct 6, 2017

Welcome @JamesMGreene and thank you for the contribution 🥇

Resumed the CI jobs that failed because of git issues:
https://ci.nodejs.org/job/node-test-commit/12825/

@JamesMGreene
Copy link
Contributor Author

Thanks for the resume, @refack. 👍

@refack refack self-assigned this Oct 6, 2017
refack pushed a commit that referenced this pull request Oct 7, 2017
@JamesMGreene @refack
test: update 'fixturesDir' refs in a test file
1c97fa7 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@refack
Copy link
Contributor

refack commented Oct 7, 2017

Landed in 1c97fa7
@JamesMGreene congratulations on being promoted from:
image
to
image

@refack refack closed this Oct 7, 2017
@JamesMGreene
Copy link
Contributor Author

\o/ :tada:

And thank you in turn to all of the Node.js collaborators and NINA17 mentors for allowing us the opportunity for an “easy in”. 👍

@JamesMGreene
Copy link
Contributor Author

I know it’s a lot more work on your end than just doing it yourselves but it’s a brilliant way to get new contributors involved.

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@JamesMGreene @MylesBorins
test: update 'fixturesDir' refs in a test file
516fda6 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@JamesMGreene @addaleax
test: update 'fixturesDir' refs in a test file
f9da2da 
This was a task from Code & Learn at NINA17.

PR-URL: nodejs/node#15824
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@JamesMGreene @MylesBorins
test: update 'fixturesDir' refs in a test file
667cbd7 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@JamesMGreene @MylesBorins
test: update 'fixturesDir' refs in a test file
ae61adf 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@JamesMGreene @MylesBorins
test: update 'fixturesDir' refs in a test file
14aee78 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelgolda pawelgolda pawelgolda left review comments

@rmg rmg rmg approved these changes

@refack refack refack approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.