test: replaces fixturesDir with fixtures #15838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmg
reviewed
Oct 6, 2017
|
|
||
| common.skipIfInspectorDisabled(); | ||
|
|
||
| const assert = require('assert'); | ||
| const execFile = require('child_process').execFile; | ||
| const path = require('path'); | ||
|
|
||
| const mainScript = path.join(common.fixturesDir, 'loop.js'); | ||
| const mainScript = path.join(fixtures.fixturesDir, 'loop.js'); |
There was a problem hiding this comment.
What do you think about using fixtures.path('loop.js') to replace path.join(..., 'loop.js') and make this even simpler?
Trott
added
the
code-and-learn
|
should I squash the commits? |
|
@alireza-a You can do that, or whoever lands this will take care of it. |
gibfahn
approved these changes
Oct 8, 2017
jasnell
approved these changes
Oct 10, 2017
joyeecheung
approved these changes
Oct 10, 2017
|
Landed in 7ba896e, thanks for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 10, 2017
PR-URL: #15838 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15838 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15838 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)