Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url accessor fixes #1589

Closed
wants to merge 2 commits into from
Closed

Url accessor fixes #1589

wants to merge 2 commits into from

Commits on May 2, 2015

  1. url: delete href cache on all setter code paths

    @petkaantonov
    petkaantonov committed May 2, 2015
    Configuration menu
    Copy the full SHA
    7702b0d View commit details
    Browse the repository at this point in the history

  2. url: fix treatment of some values as non-empty 

    In addition to null, undefined and the empty string
are treated as empty (removing the component from the url).

The string '#' is treated same as empty values when
setting .hash.

The string '?' is treated same as empty values when
setting .search.

Fixes nodejs#1588
    @petkaantonov
    petkaantonov committed May 2, 2015
    Configuration menu
    Copy the full SHA
    e274b92 View commit details
    Browse the repository at this point in the history