test: replace common.fixturesDir with common.fixtures in test-debugger-debug-brk #15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penDerGraft
commented
Oct 6, 2017
| const assert = require('assert'); | ||
| const spawn = require('child_process').spawn; | ||
|
|
||
| const script = `${common.fixturesDir}/empty.js`; | ||
| // file name here doesn't actually matter since | ||
| // debugger will connect regardless of file name arg |
There was a problem hiding this comment.
I was confused why the test was passing regardless of the file name so I added this comment. Talked with @Trott about this. Happy to remove if this is common knowledge!
Trott
added
the
code-and-learn
benjamingr
approved these changes
Oct 7, 2017
BridgeAR
approved these changes
Oct 9, 2017
Trott
approved these changes
Oct 9, 2017
tniessen
approved these changes
Oct 9, 2017
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #15919 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in 261ae7f Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
|
Thanks everybody! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15919 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15919 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)