test: refactor http2 test to use the fixtures module #15934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 7, 2017
| @@ -1,38 +1,32 @@ | |||
| 'use strict'; | |||
|
|
|||
| const common = require('../common'); | |||
| const { readSync, readKey, path } = require('../common/fixtures'); | |||
There was a problem hiding this comment.
In this case I think it would be best to not use destructuring because path is a Node.js module and the name is conflicting. It is just confusing that it does not stand for the same.
There was a problem hiding this comment.
Thank you for the feedback. I addressed the issue.
Avoid confusion with the path module
BridgeAR
approved these changes
Oct 8, 2017
TimothyGu
approved these changes
Oct 8, 2017
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 8, 2017
PR-URL: nodejs#15934 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
|
Landed in 96221c2 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15934 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15934 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)