[v8.x backport] crypto: make createXYZ inlineable #16446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit increase by around 10% hot code paths that are hitting createXYZ functions. Before this change the createXYZ called the XYZ constructor without new. PR-URL: nodejs#16067 Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs-github-bot
added
crypto
3 tasks
gibfahn
force-pushed
the
v8.x-staging
branch
5 times, most recently
from
b183192
to
fc8acc8
Compare
gibfahn
added
the
baking-for-lts
|
Leaving this to bake for a while in 8.x sounds good to me (#16067 (comment)) Unfortunately that probably means this will have conflicts at some point. @lpinca don't worry about rebasing until someone pings you 😁 . |
gibfahn
force-pushed
the
v8.x-staging
branch
2 times, most recently
from
97c2301
to
ab0d7a6
Compare
BridgeAR
approved these changes
Nov 23, 2017
MylesBorins
force-pushed
the
v8.x-staging
branch
from
468562c
to
b05ef97
Compare
|
Ping @nodejs/lts. I think this has baked long enough, probably burnt by now :) |
|
Thanks for the ping @lpinca |
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
This commit increase by around 10% hot code paths that are hitting createXYZ functions. Before this change the createXYZ called the XYZ constructor without new. PR-URL: #16067 Backport-PR-URL: #16446 Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 64164c7 |
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit increase by around 10% hot code paths that are hitting createXYZ functions. Before this change the createXYZ called the XYZ constructor without new. PR-URL: #16067 Backport-PR-URL: #16446 Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #16067 as requested.
cc: @MylesBorins