Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove throws in set/getHiddenValue #16544

Closed
wants to merge 2 commits into from
Closed

src: remove throws in set/getHiddenValue #16544

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 27, 2017 •
edited
Loading

setHiddenValue() and getHiddenValue() are internal only utility functions, CHECK instead of throw

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Oct 27, 2017
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 27, 2017
jasnell
jasnell commented Oct 27, 2017
View reviewed changes
lib/repl.js
@@ -287,7 +287,8 @@ function REPLServer(prompt,
const top = replMap.get(self);
const pstrace = Error.prepareStackTrace;
Error.prepareStackTrace = prepareStackTrace(pstrace);
internalUtil.decorateErrorStack(e);
if (typeof e === 'object')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to protect against the odd random non-object being emitted on the domain error event. If e is not an object, it will trigger the CHECK

@nodejs nodejs deleted a comment from salmanwaheed Oct 27, 2017
@nodejs nodejs deleted a comment from salmanwaheed Oct 27, 2017
lpinca
lpinca reviewed Oct 27, 2017
View reviewed changes
test/parallel/test-util-internal.js Outdated
assert.throws(getHiddenValue(85, 'foo'), errMessageObj);
assert.throws(getHiddenValue({}), errMessageIndex);
assert.throws(getHiddenValue({}, null), errMessageIndex);
assert.throws(getHiddenValue({}, []), errMessageIndex);
assert.deepStrictEqual(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not sure why this uses deepStrictEqual. I think it should be strictEqual.

@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2017

ping @nodejs/tsc

@jasnell
src: remove throws in set/getHiddenValue
7925adc 
These are internal only utility functions, CHECK instead of throw
mcollina
mcollina approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Nov 2, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11137/

@jasnell
Copy link
Member Author

jasnell commented Nov 2, 2017

Failures in CI are entirely unrelated.

jasnell added a commit that referenced this pull request Nov 2, 2017
@jasnell
src: remove throws in set/getHiddenValue
3d20190 
These are internal only utility functions, CHECK instead of throw

PR-URL: #16544
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Nov 2, 2017

Landed in 3d20190

@jasnell jasnell closed this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @apapirovski @mcollina @lpinca @joyeecheung @nodejs-github-bot