Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: include file mode in assert message #16815

Conversation

sastan
Copy link
Contributor

@sastan sastan commented Nov 6, 2017

If the REPL history file is created with an invalid mode include
the failed mode in the error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, repl

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.
@sastan sastan force-pushed the review-assert-usage-in-test-repl-history-perms branch from f58e401 to 5f5d6f6 Compare November 6, 2017 15:28
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Nov 6, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 7, 2017

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Looks like Ci was having issues. Let's try agian.

CI: https://ci.nodejs.org/job/node-test-pull-request/11249/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: nodejs#16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 7, 2017

Landed in 79f90f3.

@Trott Trott closed this Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: nodejs#16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: #16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: #16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: #16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: #16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants