Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change assert messages #16820

Closed
wants to merge 1 commit into from
Closed

Conversation

PaulBlanche
Copy link
Contributor

@PaulBlanche PaulBlanche commented Nov 6, 2017

Exceptions that were thrown when they shouldn't were lost.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

Exceptions that were thrown when they shouldn't were lost.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 6, 2017
@gireeshpunathil
Copy link
Member

@PaulBlanche - looks like you pushed changed without:

#git config --global user.name
#git config --global user.email

on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again?

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@vsemozhetbyt
Copy link
Contributor

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 8, 2017
Include unexpected value in assertion messages.

PR-URL: nodejs#16820
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 8, 2017

Landed in e04d23c.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 8, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
Include unexpected value in assertion messages.

PR-URL: #16820
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
Include unexpected value in assertion messages.

PR-URL: #16820
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Dec 20, 2017
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
Include unexpected value in assertion messages.

PR-URL: nodejs#16820
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Include unexpected value in assertion messages.

Backport-PR-URL: #19447
PR-URL: #16820
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants