Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty, test: refactor exports and add coverage #16959

Merged
merged 2 commits into from
Nov 14, 2017
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 12, 2017

This PR updates the tty module's exports to be more aligned with other core modules. It also adds test coverage (I believe to 100%).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tty, test

@nodejs-github-bot nodejs-github-bot added the tty Issues and PRs related to the tty subsystem. label Nov 12, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 14, 2017

This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: nodejs#16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: nodejs#16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 14, 2017

CI failures appear unrelated.

@cjihrig cjihrig merged commit 4b5a816 into nodejs:master Nov 14, 2017
@cjihrig cjihrig deleted the tty branch November 14, 2017 22:41
MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
PR-URL: #16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
PR-URL: #16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
PR-URL: #16959
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented Dec 13, 2017

@cjihrig this one was two commits, please do the

Landed in 8ae4e1c 4b5a816

thing.

This was referenced Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tty Issues and PRs related to the tty subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants