Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix linting error #17251

Closed
wants to merge 1 commit into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 22, 2017

571ecd1 landing with a make lint error. This is necessary to fix it. We should fast track to unbreak master.

/cc @lance

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
jasnell referenced this pull request Nov 22, 2017
Using an arrow function here eliminates the need to call `bind()`.

PR-URL: #17202
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Nov 22, 2017

jasnell added a commit that referenced this pull request Nov 22, 2017
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Nov 22, 2017

Landed in cf5ad75

@jasnell jasnell closed this Nov 22, 2017
@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants