Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix typo in gen-postmortem-metadata.py #17268

Closed
wants to merge 1 commit into from
Closed

tools: fix typo in gen-postmortem-metadata.py #17268

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 23, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 23, 2017
@targos
Copy link
Member

targos commented Nov 23, 2017

This doesn't need to wait two days.

danbev added a commit that referenced this pull request Nov 23, 2017
@danbev
tools: fix typo in gen-postmortem-metadata.py
e46c3f7 
PR-URL: #17268
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Nov 23, 2017

Landed in e46c3f7

@danbev danbev closed this Nov 23, 2017
@danbev danbev deleted the gen-postmortem-metadata-typo branch November 23, 2017 08:35
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
tools: fix typo in gen-postmortem-metadata.py
2247f97 
PR-URL: #17268
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @targos @lpinca @richardlau @vsemozhetbyt @MylesBorins @nodejs-github-bot