Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src, tools: add debug symbols for node internals" #17272

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Revert "src, tools: add debug symbols for node internals" #17272

merged 1 commit into from
Nov 23, 2017
+1 −225

Commits on Nov 23, 2017

  1. Revert "src, tools: add debug symbols for node internals" 

    This reverts commit 446c1ec.

Reverted for breaking `make test-v8`.  The "find all relevant system
headers" logic in `tools/gen-postmortem-metadata.py` needs more work.

Also reverts commit e46c3f7.
("tools: fix typo in gen-postmortem-metadata.py".)

PR-URL: nodejs#17272
Refs: nodejs#14901
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
    @bnoordhuis
    bnoordhuis committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    088bba3 View commit details
    Browse the repository at this point in the history