Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test cases in test-http-status-reason-invalid-chars to use countdown #17342

Closed
wants to merge 1 commit into from

Conversation

mithunsasidharan
Copy link
Contributor

Refactored test-http-status-reason-invalid-chars file to use countdown as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 27, 2017
@mithunsasidharan mithunsasidharan changed the title Refactored test-http-status-reason-invalid-chars file to use countdown refactor: test cases in test-http-status-reason-invalid-chars to use countdown Nov 27, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 27, 2017
@maclover7
Copy link
Contributor

@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Can you please run the CI for this too ?

@apapirovski
Copy link
Member

@mithunsasidharan looks like there's a CI from before that came back green other than known failures. This should be ready to land whenever someone gets a chance.

@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Thank you !

@maclover7
Copy link
Contributor

Landing...

@maclover7 maclover7 self-assigned this Dec 3, 2017
@maclover7
Copy link
Contributor

Thank you for your contribution, landed in 2afd4e7.
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 3, 2017
maclover7 pushed a commit that referenced this pull request Dec 3, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants