Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: use Reflect.apply #17514

Closed
wants to merge 1 commit into from
Closed

fs: use Reflect.apply #17514

wants to merge 1 commit into from

Conversation

starkwang
Copy link
Contributor

Refs: #17456, #12956

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@starkwang
fs: use Reflect.apply
ed89afa 
Using Reflect.apply is both safer and appears to offer
a slight performance benefit.
@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Dec 7, 2017
@apapirovski
Copy link
Member

apapirovski commented Dec 7, 2017 •
edited
Loading

Hi @starkwang — thanks for taking this on, it appears the is an earlier PR for this same change: #17486

@starkwang
Copy link
Contributor Author

@apapirovski OK, I will close it

@starkwang starkwang closed this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starkwang @apapirovski @cjihrig @nodejs-github-bot