-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in CONTRIBUTING.md #1755
Conversation
LGTM |
I would phrase that as
But I am not a native English speaker and can't vote, it's just that |
@ChALkeR The period inside the parenthesis is technically correct if the parenthesized text isn't part of a prior sentence, or so I have been taught. |
@Fishrock123 True. But is that really the way how that is usually written? I mean the choice between «Aaaa. (Bbbb.)» and «Aaaa (bbbb).» wording. Edit: Ok, nevermind. Just forget that, it's not important ☺. |
Have to admit, a dot inside a parens looks weird to me too. |
I'm afraid there's no wiggle room on where to put the period unless the content is reworded. This is the iron-clad direction of every major style guide for written English. (Er, well, the style guides I cite below are for US English, so it's possible that the rules are different in UK et al.)
|
PR-URL: #1755 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Thanks, landed in 2bb2f06 |
Fix minor typographical errors