Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: make console more standard compliant #17708

Closed
wants to merge 3 commits into from
Closed

console: make console more standard compliant #17708

wants to merge 3 commits into from

Commits on Jan 16, 2018

  1. lib: make console writable and non-enumerable 

    According to the standard the property descriptor of console
should be writable and non-enumerable.

Fixes: nodejs#11805
    @BridgeAR
    BridgeAR committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    e6b42ee View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. test: add standard console tests 

    This imports a standard test from w3c/web-platform-tests
(console-is-a-namespace).
    @Wandalen @BridgeAR
    Wandalen authored and BridgeAR committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    b7ce7b3 View commit details
    Browse the repository at this point in the history

  2. test: improve console tests

    @BridgeAR
    BridgeAR committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    1193065 View commit details
    Browse the repository at this point in the history