Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

Closed
wants to merge 5 commits into from
Closed

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

wants to merge 5 commits into from

Commits on Dec 17, 2017

  1. tools: auto fix custom eslint rule for lowercase-name-for-primitive.js 

    1. Fixer for lowercase-name-for-primitive.js
2. Modified the node passed to fix it.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    a389548 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. tools: auto fix custom eslint rule for lowercase-name-for-primitive.js 

    1. Extends test cases with output scenarios.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    b2d1f5b View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. tools: auto fix custom eslint rule for lowercase-name-for-primitive.js 

    1. Changes as per review comments.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    42009c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2017

  1. tools: auto fix custom eslint rule for lowercase-name-for-primitive.js 

    1. Fixed test with proper quotes.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    1799ec3 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2017

  1. tools: auto fix custom eslint rule for lowercase-name-for-primitive.js 

    1. Removes template string
2. Uses escaped quote.

Refs : nodejs#16636
    @shobhitchittora
    shobhitchittora committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    a23ca88 View commit details
    Browse the repository at this point in the history