_tls_wrap: Migrate the errors to internal/errors #17709 #17792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
mannanali413
changed the title
jasnell
reviewed
Dec 20, 2017
doc/api/errors.md
Outdated
| ### ERR_TLS_RENEGOTIATION_DISABLED | ||
|
|
||
| This errors is triggered when attempts are made to renegotiate TLS on a socket | ||
| instance which has TLS disabled |
There was a problem hiding this comment.
The description is not quite accurate. Perhaps:
Triggered when an attempt is made to renegotiate the secure configuration on a TLS
socket after renegotiation has been disabled.
There was a problem hiding this comment.
For consistency with other error descriptions, this should start with An attempt was made...
jasnell
added
the
semver-major
This migrates the old style error messages to use internal/errors.js Fixes: nodejs#17709
This commit follows the previous commit. Tested Linting and added this commit Fixes: nodejs#17709
This migrates the old style error messages to use internal/errors.js Fixes: nodejs#17709
This commit follows the previous commit. Tested Linting and added this commit Fixes: nodejs#17709
…TIATION_DISABLED This commit paraphrases the error message corresponding to the ERR_TLS_RENEGOTIATION_DISABLED key, so as to ensure consistency with the other error messages. Fixes: nodejs#17709
mannanali413
force-pushed
the
fix/errors-17709
branch
from
d2e16af
to
55dabaf
Compare
|
@jasnell I have paraphrased the message. Please let me know if this works :) |
addaleax
approved these changes
Dec 23, 2017
doc/api/errors.md
Outdated
| <a id="ERR_TLS_RENEGOTIATION_DISABLED"></a> | ||
| ### ERR_TLS_RENEGOTIATION_DISABLED | ||
|
|
||
| An attempt was made to renegotiate TLS on a socket instance with TLS disabled. |
There was a problem hiding this comment.
tiny tiny nit: there is an extra space before disabled ;)
Remove the extra space in the message corresponding to the key ERR_TLS_RENEGOTIATION_DISABLED . Fixes: nodejs#17709
maclover7
approved these changes
Dec 23, 2017
joyeecheung
approved these changes
Dec 23, 2017
joyeecheung
added
the
author ready
|
Landed in 79261f3, thanks for the contribution and welcome to Node.js! |
joyeecheung
pushed a commit
that referenced
this pull request
Dec 23, 2017
This migrates the old style error in _tls_wrap.js to the new style error ERR_TLS_RENEGOTIATION_DISABLED. Refs: #17709 PR-URL: #17792 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung
removed
the
author ready
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #17709
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
The
doc/api/errors.mdfile has been modified to include theERR_TLS_RENEGOTIATION_DISABLEDerror .Also, modified the files
lib/_tls_wrap.js,lib/internal/errors.js,test/parallel/test-tls-disable-renegotiation.jsso as to add theERR_TLS_RENEGOTIATION_DISABLEDerror