Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use smaller input file for test-zlib.js #17988

Closed
wants to merge 1 commit into from
Closed

test: use smaller input file for test-zlib.js #17988

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 5, 2018

Fixes: #17986

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott Trott added test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem. labels Jan 5, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2018
@Trott Trott mentioned this pull request Jan 5, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Jan 5, 2018

ping @MylesBorins (who wrote this test case in 241eb6122ee)

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 5, 2018
@Trott
Copy link
Member Author

Trott commented Jan 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12424/

jasnell pushed a commit that referenced this pull request Jan 10, 2018
@Trott @jasnell
test: use smaller input file for test-zlib.js
bf2e964 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2018

Landed in bf2e964

@jasnell jasnell closed this Jan 10, 2018
evanlucas pushed a commit that referenced this pull request Jan 22, 2018
@Trott @evanlucas
test: use smaller input file for test-zlib.js
8778090 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@Trott @evanlucas
test: use smaller input file for test-zlib.js
3456e61 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@Trott @MylesBorins
test: use smaller input file for test-zlib.js
66a19cf 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@Trott @MylesBorins
test: use smaller input file for test-zlib.js
16ef24b 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
This was referenced Feb 27, 2018
Closed
Merged
@Trott Trott deleted the reduce-mem-footprint branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please use less memory in test-zlib
9 participants
@Trott @jasnell @lpinca @cjihrig @gireeshpunathil @BridgeAR @gibfahn @MylesBorins @nodejs-github-bot