Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add more detail for callback of http res/req end method #181

Closed
wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

Add documentation for the callback parameter of http.ClientRequest's and
http.ServerResponse's end methods.

Add documentation for the callback parameter of http.ClientRequest's and
http.ServerResponse's end methods.
@brendanashworth
Copy link
Contributor

Original PR URL: joyent/node#8851. BTW, there is still a chance that it could get merged at joyent/node, so you might want to re-open the original PR.

This pull request gets a 👍 from me, it doesn't make much sense to leave the callback parameter undocumented.

bnoordhuis pushed a commit that referenced this pull request Dec 18, 2014
Add documentation for the callback parameter of http.ClientRequest's and
http.ServerResponse's end methods.

PR-URL: #181
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Brendan Ashworth <[email protected]>
@bnoordhuis
Copy link
Member

Landed in a553267, cheers!

@bnoordhuis bnoordhuis closed this Dec 18, 2014
@chrisdickinson
Copy link
Contributor

@brendanashworth For the future, could you rephrase "would you be interested in re-opening this PR at iojs" to "are you still interested in maintaining this PR?" and CC me on the issue? I'll try to make sure it gets into joyent/node, I'll try to make sure it makes it in here as well.

@brendanashworth
Copy link
Contributor

@chrisdickinson sure! Thanks for the tip.

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Feb 16, 2016
jasongin added a commit to jasongin/nodejs that referenced this pull request Mar 23, 2017
boingoing pushed a commit to boingoing/node that referenced this pull request Apr 6, 2017
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request May 28, 2024
* Add node_enable_deprecated_declarations_warnings GN flag

Warnings about using deprecated declarations were disabled by default
which made it hard to ensure that Node doesn't use V8's deprecated
Apis.

The flag allows enabling deprecated warnings and suppresses (hopefully)
known issues with using deprecated functionality in c-api.

The flag is off by default which preserves the existing behavior.

Drive-by: fix deps/openssl/unofficial.gni by exposing the required
OpenSSL compatibility level (OPENSSL_API_COMPAT) via public_configs.
syg pushed a commit to syg/node that referenced this pull request Jun 20, 2024
* Add node_enable_deprecated_declarations_warnings GN flag

Warnings about using deprecated declarations were disabled by default
which made it hard to ensure that Node doesn't use V8's deprecated
Apis.

The flag allows enabling deprecated warnings and suppresses (hopefully)
known issues with using deprecated functionality in c-api.

The flag is off by default which preserves the existing behavior.

Drive-by: fix deps/openssl/unofficial.gni by exposing the required
OpenSSL compatibility level (OPENSSL_API_COMPAT) via public_configs.
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request Aug 28, 2024
* Add node_enable_deprecated_declarations_warnings GN flag

Warnings about using deprecated declarations were disabled by default
which made it hard to ensure that Node doesn't use V8's deprecated
Apis.

The flag allows enabling deprecated warnings and suppresses (hopefully)
known issues with using deprecated functionality in c-api.

The flag is off by default which preserves the existing behavior.

Drive-by: fix deps/openssl/unofficial.gni by exposing the required
OpenSSL compatibility level (OPENSSL_API_COMPAT) via public_configs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants