Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: use AliasedBuffer for fs_stats_field_array #18276

Closed
wants to merge 1 commit into from
Closed

fs: use AliasedBuffer for fs_stats_field_array #18276

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 21, 2018
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12648/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 22, 2018
@joyeecheung
Copy link
Member Author

Only a known flake on Windows.

@joyeecheung
Copy link
Member Author

Landed in d09d878, thanks!

joyeecheung added a commit that referenced this pull request Jan 23, 2018
@joyeecheung
fs: use AliasedBuffer for fs_stats_field_array
d09d878 
PR-URL: #18276
Reviewed-By: James M Snell <[email protected]>
@joyeecheung joyeecheung removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2018
@MylesBorins
Copy link
Contributor

This does not land cleanly on v9.x, could it be manually backported?

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung @MayaLekova
fs: use AliasedBuffer for fs_stats_field_array
14be5f3 
PR-URL: nodejs#18276
Reviewed-By: James M Snell <[email protected]>
@codebytere
Copy link
Member

@joyeecheung this doesn't land cleanly on v8.x either, do you think it should be backported there?

@jasnell
Copy link
Member

jasnell commented Aug 17, 2018

This depends on some semver-major changes that aren't in 8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @MylesBorins @codebytere @jasnell @nodejs-github-bot