Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-fs-write #18374

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-fs-write #18374

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Attempt to fix #18371

cc @BridgeAR will need the OS type to run stress test to reproduce

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2018
@joyeecheung
Copy link
Member Author

Stress tests on ubuntu 1710

master: https://ci.nodejs.org/job/node-stress-single-test/1753/
this PR: https://ci.nodejs.org/job/node-stress-single-test/1754/

@joyeecheung
Copy link
Member Author

Could not run the stress test because the common.refreshTmpDir() is not called early enough.

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 25, 2018 •
edited
Loading

Fixed the common.refreshTmpDir() call.

Stress test against this PR: https://ci.nodejs.org/job/node-stress-single-test/1755/

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 26, 2018 •
edited
Loading

Stress test is clean. cc @BridgeAR can you check if this patch fix the issue for you?

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 26, 2018
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12769/

@joyeecheung
Copy link
Member Author

Landed in 94e36f1, thanks!

joyeecheung added a commit that referenced this pull request Jan 29, 2018
@joyeecheung
test: fix flaky test-fs-write
94e36f1 
PR-URL: #18374
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@joyeecheung joyeecheung removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2018
@MylesBorins
Copy link
Contributor

This does not land cleanly on v9.x, should it be backported?

@joyeecheung
Copy link
Member Author

This seems to be already backported by other people.

@targos
Copy link
Member

targos commented Apr 2, 2018

This commit is not in v9.x. I'm labeling dont-land. I don't think it has been flaky in this branch.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung @MayaLekova
test: fix flaky test-fs-write
467c518 
PR-URL: nodejs#18374
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test-fs-write
9 participants
@joyeecheung @MylesBorins @targos @jasnell @cjihrig @richardlau @gireeshpunathil @codebytere @nodejs-github-bot