lib: include missing profiler file #18455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes deps/v8/tools/arguments.js, which is needed by the profiler.
nodejs-github-bot
added
build
bnoordhuis
approved these changes
Jan 30, 2018
|
The tick processor tests are flaky for me since the V8 6.3 update in #16271. The changes in this PR don't fix the flakiness, but it does make it run again. Things seem to run fine outside of the tests though. |
jasnell
approved these changes
Jan 31, 2018
BridgeAR
added
the
author ready
|
CI should be good but trying again on arm just to be safe: https://ci.nodejs.org/job/node-test-commit-arm-fanned/14179/ |
jasnell
pushed a commit
that referenced
this pull request
Feb 2, 2018
This commit includes deps/v8/tools/arguments.js, which is needed by the profiler. PR-URL: #18455 Fixes: #18451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 42258d7 |
addaleax
removed
the
author ready
|
The original bug does not seem to affect v9.x so setting as don't land. Please feel free to change this /cc @nodejs/v8 |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit includes deps/v8/tools/arguments.js, which is needed by the profiler. PR-URL: nodejs#18455 Fixes: nodejs#18451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes
deps/v8/tools/arguments.js, which is needed by the profiler.Fixes: #18451
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib