Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] backport defaultTriggerAsyncIdScope changes #18474

Closed
wants to merge 3 commits into from
Closed

[v9.x backport] backport defaultTriggerAsyncIdScope changes #18474

wants to merge 3 commits into from

Commits on Jan 30, 2018

  1. async_hooks: update defaultTriggerAsyncIdScope for perf 

    The existing version of defaultTriggerAsyncIdScope creates an Array
for the callback's arguments which is highly inefficient. Instead,
use rest syntax and allow V8 to do that work for us. This yields
roughly 2x performance for this particular function.

PR-URL: #18004
Reviewed-By: Andreas Madsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @apapirovski @AndreasMadsen
    apapirovski authored and AndreasMadsen committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    1c086e4 View commit details
    Browse the repository at this point in the history

  2. async_hooks,http: set HTTPParser trigger to socket 

    This allows more easy tracking of where HTTP requests come from. Before
this change the HTTPParser would have the HTTPServer as the
triggerAsyncId.

The HTTPParser will still have the executionAsyncId set to the HTTP
Server so that information is still directly available. Indirectly, the
TCP socket itself also has its triggerAsyncId set to the TCP Server.

PR-URL: #18003
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
    @AndreasMadsen
    AndreasMadsen committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    731c0d9 View commit details
    Browse the repository at this point in the history

  3. async_hooks,test: only use IPv6 in http test 

    If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

PR-URL: #18143
Fixes: #18003
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @AndreasMadsen
    AndreasMadsen committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e6794d9 View commit details
    Browse the repository at this point in the history