test: convert new tests to use error types #18581
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
node-api
| message: 'console.log is not a function' | ||
| } | ||
| ); | ||
| assert.throws(() => console.log('foo'), TypeError); |
There was a problem hiding this comment.
I'd keep this one as common.expectsError()
jackhorton
force-pushed
the
test-error-type
branch
from
5eb9d0f
to
0645304
Compare
|
Updated to expectsError. Just for my own understanding, when is it preferred to use |
|
It was originally recommended to use I personally recommend to always use |
BridgeAR
added
the
author ready
|
I have looked at a handful of the CI errors and none of them look related to this change, is that expected? OS X had a missing tool, Linux had a YAML issue, and some others didn't look like they reported why they failed at all. |
|
@jackhorton to some extend: yes. But not as bad as it has happened here. We have to many flakes and other issues with our CI at the moment as it seems. |
PR-URL: nodejs#18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 1729af2 🎉 |
|
Should this be backported to |
|
Not sure what the status quo is for this -- theres no functional update, it just makes for fewer special cases in Node-ChakraCore. I think im fine with not backporting it? |
PR-URL: nodejs#18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Backport-PR-URL: #19447 PR-URL: #18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Backport-PR-URL: #19265 PR-URL: #18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#18581 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Some new tests were added recently that rely on error messages that are incompatible with Node-ChakraCore. This PR simply reverts the test to only relying on error type, rather than error message.
vcbuild testis actually failing for me on an unrelated test, sequential/test-inspector-port-cluster, but I might make a new issue for that separately.