[backport-v8.x] backport npm/npm@4ca6958 #18616
Conversation
Original commit message:
[email protected]
Fixes Node 9 compatibility.
Credit: @isaacs
PR-URL: #16509
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
refs: npm/npm#18964 PR-URL: #16509 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs-github-bot
added
npm
There was a problem hiding this comment.
cc @nodejs/lts
IMO we should include this in #18336. Because we floated these patches on master/v9.x they were missing from the subsequent upgrade npm to 5.6.0 PR #17535 / #17777 so when they were backported without these patches we ended up with files that don't match the equivalent in https://github.com/npm/npm/blob/v5.6.0.
|
Why do we need to include the v9.x compatibility patch? EDIT: Just read #16509 (comment), fair enough I guess. |
|
So I'm leaning towards us simply relanding 5.6.0 following the instructions at https://github.com/nodejs/node/blob/master/doc/guides/maintaining-npm.md Thoughts |
|
I've opened #18625 as an alternative. In it I completely relanded 5.6.0 following our maintaining npm guide |
Sounds like a good idea to me. |
Backporting npm/npm@4ca6958 ( 9f33a24 and b8888f5) that wasn't backported in #16509
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)