Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix http.IncomingMessage.socket documentation #1867

Closed

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Jun 1, 2015

Remove the reference to net.Socket.verifyPeer().
That was removed in ea540c9 (2010) and was missed in the 032f80e (a follow-up documentation update).

Refer to the net.Socket instance by the .socket property. This avoids unneeded confusion.
.socket is the variant that is used internally (and that was mentioned two lines above in the docs).

Add a markdown link to net.Socket.getPeerCertificate().

Remove the reference to net.Socket.verifyPeer().
That was removed in ea540c9 and was missed in the 032f80e.

Refer to the net.Socket instance by the .socket property.
This avoids unneeded confusion.
'.socket' is the variant that is used internally.

Add a markdown link to net.Socket.getPeerCertificate().
@ChALkeR ChALkeR force-pushed the doc-http-incomingmessage-socket branch from 5cf9442 to cbf485a Compare June 1, 2015 21:07
@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Jun 1, 2015
@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 1, 2015

This leaves .connection and .client aliases undocumented, but I think that that's for better.

bnoordhuis pushed a commit that referenced this pull request Jun 1, 2015
Remove the reference to net.Socket.verifyPeer().
That was removed in ea540c9 and was missed in the 032f80e.

Refer to the net.Socket instance by the .socket property.
This avoids unneeded confusion.
'.socket' is the variant that is used internally.

Add a markdown link to net.Socket.getPeerCertificate().

PR-URL: #1867
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis
Copy link
Member

Landed in 89a5b90, thanks. Fixed up a long line in the process.

@bnoordhuis bnoordhuis closed this Jun 1, 2015
@ChALkeR ChALkeR deleted the doc-http-incomingmessage-socket branch June 1, 2015 22:06
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
Remove the reference to net.Socket.verifyPeer().
That was removed in ea540c9 and was missed in the 032f80e.

Refer to the net.Socket instance by the .socket property.
This avoids unneeded confusion.
'.socket' is the variant that is used internally.

Add a markdown link to net.Socket.getPeerCertificate().

PR-URL: nodejs/node#1867
Reviewed-By: Ben Noordhuis <[email protected]>
@rvagg rvagg mentioned this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants