doc: improved flow regarding firewall script for macOS in building readme #18689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
@JMGordon hi! I think you should check these two options too:
|
jasnell
reviewed
Feb 13, 2018
BUILDING.md
Outdated
|
|
||
| If the path to your build directory contains a space, the build will likely fail. | ||
|
|
||
| After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) | ||
| to avoid popups asking to accept incoming network connections when running tests. |
There was a problem hiding this comment.
nit suggestion:
After building, setting up [filewall rules](tools/macosx-firewall.sh) can avoid popups
asking to accept incoming network connections when running tests.
jasnell
approved these changes
Feb 26, 2018
|
Looks like |
richardlau
reviewed
Feb 26, 2018
BUILDING.md
Outdated
|
|
||
| If the path to your build directory contains a space, the build will likely fail. | ||
|
|
||
| After building, setting up [filewall rules](tools/macosx-firewall.sh) can avoid popups |
There was a problem hiding this comment.
I'm assuming this was a typo in the suggestion from @jasnell and that this should have remained as firewall rules.
|
@JMGordon would you be so kind and do a rebase to resolve the conflict in |
|
ping @JMGordon |
BridgeAR
force-pushed
the
build-doc-update
branch
from
7b91ffc
to
4533b9f
Compare
|
I went ahead and rebased and added a commit that addressed the typo plus a suggested change from myself. So @jasnell PTAL |
|
still lgtm |
trivikr
approved these changes
Apr 10, 2018
trivikr
pushed a commit
that referenced
this pull request
Apr 15, 2018
PR-URL: #18689 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #18689 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#18689 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some of the text around regarding setting up firewall rules on macOS to help
improve text flow.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)