Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove TODO #1875

Closed
wants to merge 1 commit into from
Closed

test: remove TODO #1875

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 3, 2015

It's not clear what additional tests are wanted.

A coverage analysis or another bug report would justify
additional tests.

Otherwise, the current malformed URL test seems adequate.

ref #264

It's not clear what additional tests are wanted.

A coverage analysis or another bug report would justify
additional tests.

Otherwise, the current malformed URL test seems adequate.
@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Jun 3, 2015
@targos
Copy link
Member

targos commented Jun 3, 2015

For some context, the comment was added in this commit: 9dbd924

@cjihrig
Copy link
Contributor

cjihrig commented Jun 3, 2015

Since the author of the original commit doesn't work on the project anymore, I'm inclined to say this LGTM.

@evanlucas
Copy link
Contributor

LGTM

jbergstroem pushed a commit that referenced this pull request Jun 4, 2015
It's not clear what additional tests are wanted.
The current malformed URL test seems adequate.

PR-URL: #1875
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@jbergstroem
Copy link
Member

Merged in 6537fd4. Thanks!

@jbergstroem jbergstroem closed this Jun 4, 2015
@rvagg rvagg mentioned this pull request Jun 11, 2015
@Trott Trott deleted the malformed branch October 14, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants