Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.4.388.45 #18751

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.4.388.45 #18751

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Feb 13, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13133/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1216/

@MylesBorins
Copy link
Contributor Author

one more ci: https://ci.nodejs.org/job/node-test-pull-request/13136/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 13, 2018
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Feb 13, 2018 •
edited
Loading

Single Plinux failure

trying one more time https://ci.nodejs.org/job/node-test-pull-request/13146/

@MylesBorins
Copy link
Contributor Author

Single plinux failure again... different failure

@MylesBorins
Copy link
Contributor Author

YET ANOTHER CI
https://ci.nodejs.org/job/node-test-pull-request/13153/

@MylesBorins
Copy link
Contributor Author

One More: https://ci.nodejs.org/job/node-test-pull-request/13160/

@MylesBorins
Copy link
Contributor Author

another ci.. sigh: https://ci.nodejs.org/job/node-test-pull-request/13181/

@targos
Copy link
Member

targos commented Feb 16, 2018

Landed in 36386dc

@targos targos closed this Feb 16, 2018
targos pushed a commit that referenced this pull request Feb 16, 2018
@MylesBorins @targos
deps: patch V8 to 6.4.388.45
36386dc 
Refs: v8/v8@6.4.388.44...6.4.388.45

PR-URL: #18751
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos deleted the V8-6.4.388.45 branch February 16, 2018 18:37
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins @MayaLekova
deps: patch V8 to 6.4.388.45
cbfc4af 
Refs: v8/v8@6.4.388.44...6.4.388.45

PR-URL: nodejs#18751
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @targos @jasnell @cjihrig @BridgeAR @nodejs-github-bot