Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: remove unused code in module.js #18768

Closed
wants to merge 1 commit into from
Closed

module: remove unused code in module.js #18768

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 13, 2018

Remove unnecessary condition in lib/module.js.

Refs: #18593 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

module

@Trott
module: remove unused code in module.js
dca2148 
Remove unnecessary condition in lib/module.js.

Refs: nodejs#18593 (comment)
@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Feb 13, 2018
@Trott
Copy link
Member Author

Trott commented Feb 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13155/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2018
Trott added a commit to Trott/io.js that referenced this pull request Feb 16, 2018
@Trott
module: remove unused code in module.js
3b9cc42 
Remove unnecessary condition in lib/module.js.

Refs: nodejs#18593 (comment)

PR-URL: nodejs#18768
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 16, 2018 •
edited by tniessen
Loading

Landed in 3b9cc42.

@Trott Trott closed this Feb 16, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
module: remove unused code in module.js
82180e5 
Remove unnecessary condition in lib/module.js.

Refs: nodejs#18593 (comment)

PR-URL: nodejs#18768
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott Trott deleted the rm-unused-module-code branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @jasnell @benjamingr @cjihrig @tniessen @richardlau @devsnek @BridgeAR @addaleax @nodejs-github-bot