Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix deprecation number #18818

Closed
wants to merge 1 commit into from
Closed

doc: fix deprecation number #18818

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Refs: efb3259

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 16, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 16, 2018
@BridgeAR
Copy link
Member Author

I do not start a CI for it as the change seems very obvious.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
@BridgeAR
Copy link
Member Author

Landed in 1bd3208

@BridgeAR BridgeAR closed this Feb 16, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
@BridgeAR
doc: fix deprecation number
1bd3208 
PR-URL: nodejs#18818
Refs: nodejs@efb3259
Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@BridgeAR @MayaLekova
doc: fix deprecation number
dcddf25 
PR-URL: nodejs#18818
Refs: nodejs@efb3259
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR deleted the fix-deprecation-number branch April 1, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @cjihrig @MylesBorins @nodejs-github-bot