Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: no stream destroy while its data is on the wire #19002

Closed
wants to merge 2 commits into from
Closed

http2: no stream destroy while its data is on the wire #19002

wants to merge 2 commits into from

Commits on Feb 26, 2018

  1. http2: no stream destroy while its data is on the wire 

    This fixes a crash that occurred when a `Http2Stream` write
is completed after it is already destroyed.

Instead, don’t destroy the stream in that case and wait for
GC to take over.

Fixes: nodejs#18973
    @addaleax
    addaleax committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    e66021e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. [squash] add requested block

    @addaleax
    addaleax committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    4140671 View commit details
    Browse the repository at this point in the history