fs: check for symlink support in fs-promises test #19018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 26, 2018
test/parallel/test-fs-promises.js
Outdated
| try { | ||
| await symlink(newPath, newLink); | ||
| } catch (err) { | ||
| // Non-admin users on Windows can't make symlinks and get EPERM. |
There was a problem hiding this comment.
Can you check that this only happens when common.isWindows === true?
There was a problem hiding this comment.
Sounds good, added that check. Thanks!
There was a problem hiding this comment.
We already have common.canCreateSymLink() for such checks.
There was a problem hiding this comment.
Much better, thanks!
sethbrenith
force-pushed
the
fs-promises-test
branch
from
5b9f52a
to
b89f851
Compare
jasnell
approved these changes
Feb 26, 2018
joyeecheung
approved these changes
Feb 27, 2018
richardlau
approved these changes
Feb 27, 2018
Leko
approved these changes
Feb 28, 2018
|
CI failed but it seems not related to this PR. |
sethbrenith
force-pushed
the
fs-promises-test
branch
from
b89f851
to
28df769
Compare
richardlau
approved these changes
Feb 28, 2018
Attempting to make symlinks as a non-administrator user in Windows causes a permission error. We need to update test-fs-promises to avoid making symlinks if the platform does not support it.
sethbrenith
force-pushed
the
fs-promises-test
branch
from
28df769
to
b7dc6f0
Compare
sethbrenith
changed the title
BridgeAR
approved these changes
Mar 1, 2018
BridgeAR
added
the
author ready
cjihrig
approved these changes
Mar 2, 2018
|
Landed in 96b2d8d |
Leko
pushed a commit
that referenced
this pull request
Mar 3, 2018
Attempting to make symlinks as a non-administrator user in Windows causes a permission error. We need to update test-fs-promises to avoid making symlinks if the platform does not support it. PR-URL: #19018 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Attempting to make symlinks as a non-administrator user in Windows causes a permission error. We need to update test-fs-promises to avoid making symlinks if the platform does not support it. PR-URL: nodejs#19018 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to make symlinks as a non-administrator user in Windows
causes a permission error. We need to update test-fs-promises to expect
this error case, as is already done in various other tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)