Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: add test cases for fsPromises" #19101

Closed
wants to merge 1 commit into from
Closed

Revert "test: add test cases for fsPromises" #19101

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 3, 2018

This reverts commit c05c73a.

The commit breaks Raspberry Pi CI.

Refs: #19064 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott
Revert "test: add test cases for fsPromises"
fd8e920 
This reverts commit c05c73a.

The commit breaks Raspberry Pi CI.

Refs: nodejs#19064 (comment)
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 3, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 3, 2018
@Trott
Copy link
Member Author

Trott commented Mar 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13464/

@Trott Trott mentioned this pull request Mar 3, 2018
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented Mar 3, 2018

(Raspberry Pi CI is green with this revert.)

Trott added a commit to Trott/io.js that referenced this pull request Mar 3, 2018
@Trott
Revert "test: add test cases for fsPromises"
4bfc03b 
This reverts commit c05c73a.

The commit breaks Raspberry Pi CI.

PR-URL: nodejs#19101
Ref: nodejs#19064 (comment)
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 3, 2018

Landed in 4bfc03b

@Trott Trott closed this Mar 3, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
Revert "test: add test cases for fsPromises"
31a8c54 
This reverts commit c05c73a.

The commit breaks Raspberry Pi CI.

PR-URL: nodejs#19101
Ref: nodejs#19064 (comment)
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott Trott deleted the revert-19064 branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @watilde @cjihrig @addaleax @nodejs-github-bot