Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add inspector usage example #19172

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Mar 6, 2018

Add a simple example showing how to use the inspector API to access
the CPU profiler.

Checklist

CI-light: https://ci.nodejs.org/view/Node.js/job/node-test-commit-light/362/ https://ci.nodejs.org/view/Node.js/job/node-test-commit-light/365/

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Mar 6, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2018

Seems like there is a linter issue @ofrobots

@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 6, 2018

Fixed.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2018

session.post('Profiler.enable', () => {
session.post('Profiler.start', () => {
// invoke business logic under meansurement here...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: meansurement -> measurement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.


### CPU Profiler

Apart from debugger, various V8 Profilers are available through the DevTools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from debugger -> Apart from the debugger perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: nodejs#19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@ofrobots ofrobots merged commit fbf7ff9 into nodejs:master Mar 8, 2018
@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 8, 2018

Landed as fbf7ff9.

@ofrobots ofrobots deleted the inspector-profile-example branch March 8, 2018 01:10
targos pushed a commit that referenced this pull request Mar 17, 2018
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: #19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: #19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: nodejs#19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: nodejs#19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
Add a simple example showing how to use the inspector API to access
the CPU profiler.

Backport-PR-URL: #22380
PR-URL: #19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants