Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update username and email #19338

Closed
wants to merge 1 commit into from
Closed

doc: update username and email #19338

wants to merge 1 commit into from
+2 −2

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Mar 14, 2018

Modify Yuta Hiroto's account information.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2018
@hiroppy
Copy link
Member Author

hiroppy commented Mar 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/258/

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 14, 2018
MylesBorins
MylesBorins approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiroppy
Copy link
Member Author

hiroppy commented Mar 14, 2018

This pr does not need to wait 24h so I wold like to merge:) Thank you for reviewing.

hiroppy added a commit that referenced this pull request Mar 14, 2018
@hiroppy
doc: update username and email
0a56a1b 
PR-URL: #19338
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@hiroppy
Copy link
Member Author

hiroppy commented Mar 14, 2018

Landed in 0a56a1b.

@hiroppy hiroppy closed this Mar 14, 2018
@hiroppy hiroppy deleted the feature/modify-my-account branch March 14, 2018 11:55
targos pushed a commit that referenced this pull request Mar 17, 2018
@hiroppy @targos
doc: update username and email
f2f3ef2 
PR-URL: #19338
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@hiroppy @MylesBorins
doc: update username and email
7f652c2 
PR-URL: #19338
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@hiroppy @MayaLekova
doc: update username and email
e6405c1 
PR-URL: nodejs#19338
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@hiroppy @BethGriggs
doc: update username and email
5b9af6e 
PR-URL: #19338
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@Trott Trott Trott approved these changes

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.